linux-kernel - Re: [PATCH net v2] net: mvpp2: cls: Add missing NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190513.085104.1611937467438995000.davem@davemloft.net>
Date:   Mon, 13 May 2019 08:51:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     maxime.chevallier@...tlin.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        antoine.tenart@...tlin.com, thomas.petazzoni@...tlin.com,
        gregory.clement@...tlin.com, miquel.raynal@...tlin.com,
        nadavh@...vell.com, stefanc@...vell.com, mw@...ihalf.com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        jakub.kicinski@...ronome.com
Subject: Re: [PATCH net v2] net: mvpp2: cls: Add missing NETIF_F_NTUPLE flag

From: Maxime Chevallier <maxime.chevallier@...tlin.com>
Date: Mon, 13 May 2019 09:30:33 +0200

> Now that the mvpp2 driver supports classification offloading, we must
> add the NETIF_F_NTUPLE to the features list.
> 
> Since the current code doesn't allow disabling the feature, we don't set
> the flag in dev->hw_features.
> 
> Fixes: 90b509b39ac9 ("net: mvpp2: cls: Add Classification offload support")
> Reported-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> ---
> V2: Rebased on latest -net, added Jakub's Ack, gave more details in the
>     commit log about not adding the flag in hw_features.

Applied, thanks.