linux-kernel - Re: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190515110851.GD5613@sirena.org.uk>
Date:   Wed, 15 May 2019 12:08:51 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Keerthy <j-keerthy@...com>
Cc:     lee.jones@...aro.org, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-omap@...r.kernel.org, t-kristo@...com
Subject: Re: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator
 support

On Wed, May 15, 2019 at 03:38:48PM +0530, Keerthy wrote:

> @@ -172,6 +178,9 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
>  	if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
>  		min_idx = LP87565_BUCK_10;
>  		max_idx = LP87565_BUCK_23;
> +	} else if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87561_Q1) {
> +		min_idx = LP87565_BUCK_3210;
> +		max_idx = LP87565_BUCK_3210;

This if/else chain should be a switch statement.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)