linux-kernel - Re: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82581f9a-5aaa-b56c-f9d5-4188b60b3e6b@ti.com>
Date:   Wed, 15 May 2019 16:43:39 +0530
From:   Keerthy <j-keerthy@...com>
To:     Mark Brown <broonie@...nel.org>
CC:     <lee.jones@...aro.org>, <robh+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <t-kristo@...com>
Subject: Re: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator
 support



On 15/05/19 4:38 PM, Mark Brown wrote:
> On Wed, May 15, 2019 at 03:38:48PM +0530, Keerthy wrote:
> 
>> @@ -172,6 +178,9 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
>>   	if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
>>   		min_idx = LP87565_BUCK_10;
>>   		max_idx = LP87565_BUCK_23;
>> +	} else if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87561_Q1) {
>> +		min_idx = LP87565_BUCK_3210;
>> +		max_idx = LP87565_BUCK_3210;
> 
> This if/else chain should be a switch statement.

Okay. I will convert that in v2.

Thanks,
Keerthy

>