[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e7a0bff9-ee4a-0842-3e4d-c3e0da9e8523@linaro.org>
Date: Wed, 15 May 2019 07:49:20 -0500
From: Alex Elder <elder@...aro.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: David Miller <davem@...emloft.net>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Ilias Apalodimas <ilias.apalodimas@...aro.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
Andy Gross <andy.gross@...aro.org>,
Olof Johansson <olof@...om.net>,
Maxime Ripard <maxime.ripard@...tlin.com>,
Simon Horman <horms+renesas@...ge.net.au>,
Jagan Teki <jagan@...rulasolutions.com>,
Stefan Wahren <stefan.wahren@...e.com>,
Marc Gonzalez <marc.w.gonzalez@...e.fr>,
Enric Balletbo i Serra <enric.balletbo@...labora.com>,
syadagir@...eaurora.org, mjavid@...eaurora.org,
evgreen@...omium.org, Ben Chan <benchan@...gle.com>,
Eric Caruso <ejcaruso@...gle.com>, abhishek.esse@...il.com,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 18/18] arm64: defconfig: enable build of IPA code
On 5/15/19 3:23 AM, Arnd Bergmann wrote:
> On Sun, May 12, 2019 at 3:25 AM Alex Elder <elder@...aro.org> wrote:
>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 2d9c39033c1a..4f4d803e563d 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -268,6 +268,7 @@ CONFIG_SMSC911X=y
>> CONFIG_SNI_AVE=y
>> CONFIG_SNI_NETSEC=y
>> CONFIG_STMMAC_ETH=m
>> +CONFIG_IPA=y
>> CONFIG_MDIO_BUS_MUX_MMIOREG=y
>> CONFIG_AT803X_PHY=m
>> CONFIG_MARVELL_PHY=m
>
> Since the device is not needed for booting, please make this
> CONFIG_IPA=m instead to keep the kernel image a little smaller.
>
> Arnd
>
Oops, yes, that was my intention but I forgot to fix that
before I sent it out. This code works as a module, but
in order to make the whole system allow the module to be both
removed and re-inserted safely, I need some work to be done
on the modem end and that's beyond my direct control. I have
been testing with it as a kernel built-in driver in the mean
time.
In any case, it is my intention to have it be normally built
as a module and I will ensure that when I send out future
revisions of this series.
-Alex
Powered by blists - more mailing lists