lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 May 2019 07:52:15 -0500 From: Alex Elder <elder@...aro.org> To: Arnd Bergmann <arnd@...db.de> Cc: David Miller <davem@...emloft.net>, Bjorn Andersson <bjorn.andersson@...aro.org>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, syadagir@...eaurora.org, mjavid@...eaurora.org, evgreen@...omium.org, Ben Chan <benchan@...gle.com>, Eric Caruso <ejcaruso@...gle.com>, abhishek.esse@...il.com, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 00/18] net: introduce Qualcomm IPA driver On 5/15/19 7:37 AM, Arnd Bergmann wrote: > On Sun, May 12, 2019 at 3:25 AM Alex Elder <elder@...aro.org> wrote: >> >> A version of this code was posted in November 2018 as an RFC. >> https://lore.kernel.org/lkml/20181107003250.5832-1-elder@linaro.org/ >> Fixes addressing all feedback received have been implemented. It >> has undergone considerable further rework since that time, and >> most of the "future work" described then has now been completed. > > I think this has turned out really well now. I've gone through the patches > today and not found any real show-stoppers, but replied with a couple of > minor things I noticed. > > I think it's probably worth rearranging the rx and tx code to avoid > the spinlocks, which would be the main optimization I can still > think of to reduce the coherency traffic. Arnd I appreciate your review *so* much. You clearly committed a significant block of time to this and your comments were very insightful and focused. I concur with everything you pointed out and will address all of your concerns when I send out v2 of the series. Thank you for your careful review. -Alex > > Arnd >
Powered by blists - more mailing lists