linux-kernel - Re: [PATCH 4.14 067/115] crypto: testmgr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 May 2019 18:31:05 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jinpu Wang <jinpuwang@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "v3.14+, only the raid10 part" <stable@...r.kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 4.14 067/115] crypto: testmgr - add AES-CFB tests

On Wed, May 15, 2019 at 05:59:38PM +0200, Jinpu Wang wrote:
> Hi Greg,
> 
> This patch causes build failure for me:
> 
> In file included from crypto/testmgr.c:54:
> crypto/testmgr.h:16081:4: error: 'const struct cipher_testvec' has no
> member named 'ptext'
>    .ptext = "\x6b\xc1\xbe\xe2\x2e\x40\x9f\x96"
>     ^~~~~
> crypto/testmgr.h:16089:4: error: 'const struct cipher_testvec' has no
> member named 'ctext'
>    .ctext = "\x3b\x3f\xd9\x2e\xb7\x2d\xad\x20"
>     ^~~~~
> crypto/testmgr.h:16097:4: error: 'const struct cipher_testvec' has no
> member named 'len'; did you mean 'klen'?
>    .len = 64,
>     ^~~
>     klen
> crypto/testmgr.h:16097:10: warning: initialization of 'const char *'
> from 'int' makes pointer from integer without a cast
> [-Wint-conversion]
>    .len = 64,
>           ^~
> crypto/testmgr.h:16097:10: note: (near initialization for
> 'aes_cfb_tv_template[0].result')
> crypto/testmgr.h:16105:4: error: 'const struct cipher_testvec' has no
> member named 'ptext'
>    .ptext = "\x6b\xc1\xbe\xe2\x2e\x40\x9f\x96"
>     ^~~~~
> crypto/testmgr.h:16113:4: error: 'const struct cipher_testvec' has no
> member named 'ctext'
>    .ctext = "\xcd\xc8\x0d\x6f\xdd\xf1\x8c\xab"
>     ^~~~~
> crypto/testmgr.h:16121:4: error: 'const struct cipher_testvec' has no
> member named 'len'; did you mean 'klen'?
>    .len = 64,
>     ^~~
>     klen
> crypto/testmgr.h:16121:10: warning: initialization of 'const char *'
> from 'int' makes pointer from integer without a cast
> [-Wint-conversion]
>    .len = 64,
>           ^~
> crypto/testmgr.h:16121:10: note: (near initialization for
> 'aes_cfb_tv_template[1].result')
> crypto/testmgr.h:16130:4: error: 'const struct cipher_testvec' has no
> member named 'ptext'
>    .ptext = "\x6b\xc1\xbe\xe2\x2e\x40\x9f\x96"
>     ^~~~~
> crypto/testmgr.h:16138:4: error: 'const struct cipher_testvec' has no
> member named 'ctext'
>    .ctext = "\xdc\x7e\x84\xbf\xda\x79\x16\x4b"
>     ^~~~~
> crypto/testmgr.h:16146:4: error: 'const struct cipher_testvec' has no
> member named 'len'; did you mean 'klen'?
>    .len = 64,
>     ^~~
>     klen
> crypto/testmgr.h:16146:10: warning: initialization of 'const char *'
> from 'int' makes pointer from integer without a cast
> [-Wint-conversion]
>    .len = 64,
>           ^~
> crypto/testmgr.h:16146:10: note: (near initialization for
> 'aes_cfb_tv_template[2].result')
>   CC      drivers/edac/wq.o
> crypto/testmgr.c:2353:23: error: 'struct cipher_test_suite' has no
> member named 'vecs'; did you mean 'dec'?
>  #define __VECS(tv) { .vecs = tv, .count = ARRAY_SIZE(tv) }
> 
> Can you drop the patch?

Yes, now dropped.  Sasha, I think I did this same thing in the past :)