linux-kernel - Re: [PATCH 4/4] uapi: Wire up the mount API syscalls on non-x86 arches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1mUoph0xwmxPfYAcRU=uhQj83VmgTfthVnQ0H1cQpHQQ@mail.gmail.com>
Date:   Thu, 16 May 2019 13:32:13 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     David Howells <dhowells@...hat.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <christian@...uner.io>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] uapi: Wire up the mount API syscalls on non-x86 arches

On Thu, May 16, 2019 at 1:24 PM David Howells <dhowells@...hat.com> wrote:
>
> Wire up the mount API syscalls on non-x86 arches.
>
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: David Howells <dhowells@...hat.com>

Reviewed-by: Arnd Bergmann <arnd@...db.de>

but found a small mistake that breaks compilation on the
asm-generic architectures:

> diff --git a/arch/arm64/include/asm/unistd32.h b/arch/arm64/include/asm/unistd32.h
> index 23f1a44acada..3734789e9f25 100644
> --- a/arch/arm64/include/asm/unistd32.h
> +++ b/arch/arm64/include/asm/unistd32.h
> @@ -874,6 +874,18 @@ __SYSCALL(__NR_io_uring_setup, sys_io_uring_setup)
>  __SYSCALL(__NR_io_uring_enter, sys_io_uring_enter)
>  #define __NR_io_uring_register 427
>  __SYSCALL(__NR_io_uring_register, sys_io_uring_register)
> +#define __NR_open_tree 428
> +__SYSCALL(__NR_open_tree, open_tree)
> +#define __NR_move_mount 429
> +__SYSCALL(__NR_move_mount, move_mount)
> +#define __NR_fsopen 430
> +__SYSCALL(__NR_fsopen, fsopen)
> +#define __NR_fsconfig 431
> +__SYSCALL(__NR_fsconfig, fsconfig)
> +#define __NR_fsmount 432
> +__SYSCALL(__NR_fsmount, fsmount)
> +#define __NR_fspick 433
> +__SYSCALL(__NR_fspick, fspick)

This needs a sys_ prefix for each of the entry point names

> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> index dee7292e1df6..29bf3bbcce78 100644
> --- a/include/uapi/asm-generic/unistd.h
> +++ b/include/uapi/asm-generic/unistd.h
> @@ -832,9 +832,21 @@ __SYSCALL(__NR_io_uring_setup, sys_io_uring_setup)
>  __SYSCALL(__NR_io_uring_enter, sys_io_uring_enter)
>  #define __NR_io_uring_register 427
>  __SYSCALL(__NR_io_uring_register, sys_io_uring_register)
> +#define __NR_open_tree 428
> +__SYSCALL(__NR_open_tree, open_tree)
> +#define __NR_move_mount 429
> +__SYSCALL(__NR_move_mount, move_mount)
> +#define __NR_fsopen 430
> +__SYSCALL(__NR_fsopen, fsopen)
> +#define __NR_fsconfig 431
> +__SYSCALL(__NR_fsconfig, fsconfig)
> +#define __NR_fsmount 432
> +__SYSCALL(__NR_fsmount, fsmount)
> +#define __NR_fspick 433
> +__SYSCALL(__NR_fspick, fspick)
>
>  #undef __NR_syscalls
> -#define __NR_syscalls 428
> +#define __NR_syscalls 434

Same here.

      Arnd