linux-kernel - Re: [PATCH] arch64: export __flush_dcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <735fc46d-69a4-6b65-f0f7-a09c2be438a8@android.com>
Date:   Mon, 20 May 2019 07:29:46 -0700
From:   Mark Salyzyn <salyzyn@...roid.com>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        Will Deacon <will.deacon@....com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arch64: export __flush_dcache_area

On 05/17/2019 02:53 PM, Catalin Marinas wrote:
> On Fri, May 17, 2019 at 12:59:56PM -0700, Mark Salyzyn wrote:
>> Some (out of tree modular) drivers feel a need to ensure
>> data is flushed to the DDR before continuing flow.
>>
>> Signed-off-by: Mark Salyzyn <salyzyn@...roid.com>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: kernel-team@...roid.com
>> ---
>>   arch/arm64/mm/cache.S | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S
>> index a194fd0e837f..70d7cb5c0bd2 100644
>> --- a/arch/arm64/mm/cache.S
>> +++ b/arch/arm64/mm/cache.S
>> @@ -120,6 +120,7 @@ ENTRY(__flush_dcache_area)
>>   	dcache_by_line_op civac, sy, x0, x1, x2, x3
>>   	ret
>>   ENDPIPROC(__flush_dcache_area)
>> +EXPORT_SYMBOL_GPL(__flush_dcache_area)
>>   
>>   /*
>>    *	__clean_dcache_area_pou(kaddr, size)
> NAK. Such drivers are doing something wrong, there is a dedicated
> in-kernel API for that handles kernel maintenance (hint: DMA).
Thanks!

-- Mark