linux-kernel - Re: net: atm: Spectre v1 fix introduced bug in bcb964012d1b in -stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190520161549.GB25789@amd>
Date:   Mon, 20 May 2019 18:15:49 +0200
From:   Pavel Machek <pavel@...x.de>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Pavel Machek <pavel@...x.de>, stable@...nel.org,
        kernel list <linux-kernel@...r.kernel.org>,
        davem@...emloft.net, gregkh@...uxfoundation.org
Subject: Re: net: atm: Spectre v1 fix introduced bug in bcb964012d1b in
 -stable

On Mon 2019-05-20 09:15:50, Gustavo A. R. Silva wrote:
> 
> 
> On 5/20/19 7:40 AM, Pavel Machek wrote:
> > 
> > In lecd_attach, if arg is < 0, it was treated as 0. Spectre v1 fix
> > changed that. Bug does not exist in mainline AFAICT.
> > 
> 
> NACK
> 
> array_index_nospec() macro returns zero if *arg* is out of bounds.

No, it does not. Take a look:

#define array_index_nospec(index, size)
...
        (typeof(_i)) (_i & _mask);
})
	
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)