linux-kernel - Re: net: atm: Spectre v1 fix introduced bug in bcb964012d1b in -stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2afe2a95-6297-4448-3942-9ba10e306e96@embeddedor.com>
Date:   Mon, 20 May 2019 11:54:59 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Pavel Machek <pavel@...x.de>
Cc:     stable@...nel.org, kernel list <linux-kernel@...r.kernel.org>,
        davem@...emloft.net, gregkh@...uxfoundation.org
Subject: Re: net: atm: Spectre v1 fix introduced bug in bcb964012d1b in
 -stable



On 5/20/19 11:15 AM, Pavel Machek wrote:
> On Mon 2019-05-20 09:15:50, Gustavo A. R. Silva wrote:
>>
>>
>> On 5/20/19 7:40 AM, Pavel Machek wrote:
>>>
>>> In lecd_attach, if arg is < 0, it was treated as 0. Spectre v1 fix
>>> changed that. Bug does not exist in mainline AFAICT.
>>>
>>
>> NACK
>>
>> array_index_nospec() macro returns zero if *arg* is out of bounds.
> 
> No, it does not. Take a look:
> 
> #define array_index_nospec(index, size)
> ...
>         (typeof(_i)) (_i & _mask);
> })
> 	

Tell me more about that _mask.

Also, don't ignore the backward compatibility; otherwise you
would be forking your own kernel.

--
Gustavo