linux-kernel - Re: [PATCH net-next] macvlan: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d623aa39-4c5c-addb-0cf7-d0c8aed63515@embeddedor.com>
Date:   Mon, 20 May 2019 13:48:04 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     David Miller <davem@...emloft.net>
Cc:     liuhangbin@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] macvlan: Mark expected switch fall-through



On 5/20/19 1:38 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
> Date: Mon, 20 May 2019 09:44:49 -0500
> 
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/macvlan.c: In function ‘macvlan_do_ioctl’:
>> drivers/net/macvlan.c:839:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    if (!net_eq(dev_net(dev), &init_net))
>>       ^
>> drivers/net/macvlan.c:841:2: note: here
>>   case SIOCGHWTSTAMP:
>>   ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> I'll apply this to 'net' since it was introduced actually by arecent
> change.
> 

OK, great. :)

Thank you.
--
Gsutavo