linux-kernel - Re: [PATCH 07/10] mfd: madera: point to the right pinctrl binding file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190520154840.64f91ad2@coco.lan>
Date:   Mon, 20 May 2019 15:48:40 -0300
From:   Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...radead.org>,
        <linux-kernel@...r.kernel.org>, Jonathan Corbet <corbet@....net>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Lee Jones <lee.jones@...aro.org>,
        <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>
Subject: Re: [PATCH 07/10] mfd: madera: point to the right pinctrl binding
 file

Em Mon, 20 May 2019 16:42:45 +0100
Charles Keepax <ckeepax@...nsource.cirrus.com> escreveu:

> On Mon, May 20, 2019 at 11:47:36AM -0300, Mauro Carvalho Chehab wrote:
> > The reference to Documentation/pinctrl.txt doesn't exist, but
> > there is an specific binding for the madera driver.
> > 
> > So, point to it.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
> > ---
> >  include/linux/mfd/madera/pdata.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/mfd/madera/pdata.h b/include/linux/mfd/madera/pdata.h
> > index 8dc852402dbb..c7e0658eb74b 100644
> > --- a/include/linux/mfd/madera/pdata.h
> > +++ b/include/linux/mfd/madera/pdata.h
> > @@ -34,7 +34,8 @@ struct madera_codec_pdata;
> >   * @micvdd:	    Substruct of pdata for the MICVDD regulator
> >   * @irq_flags:	    Mode for primary IRQ (defaults to active low)
> >   * @gpio_base:	    Base GPIO number
> > - * @gpio_configs:   Array of GPIO configurations (See Documentation/pinctrl.txt)
> > + * @gpio_configs:   Array of GPIO configurations
> > + *		    (See Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt)  
> 
> I believe this is trying to point at the generic pinctrl docs
> which now live here:
> 
> Documentation/driver-api/pinctl.rst
> 
> There is a patch to do this already:
> https://lkml.org/lkml/2019/1/9/853
> With the latest resend here:
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2001752.html

Ah, makes sense to me. 

Please ignore this one.

Thanks,
Mauro