linux-kernel - Re: [PATCH] x86/boot: Call get_rsdp_addr() after console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190521092808.GA3805@MiWiFi-R3L-srv>
Date:   Tue, 21 May 2019 17:28:08 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Dave Young <dyoung@...hat.com>, j-nomura@...jp.nec.com,
        kasong@...hat.com, fanc.fnst@...fujitsu.com, x86@...nel.org,
        kexec@...ts.infradead.org, linux-kernel@...r.kernel.org,
        hpa@...or.com, tglx@...utronix.de
Subject: Re: [PATCH] x86/boot: Call get_rsdp_addr() after console_init()

On 05/17/19 at 03:50pm, Borislav Petkov wrote:
> And now as a proper patch:
> 
> ---
> From: Borislav Petkov <bp@...e.de>
> 
> ... so that early debugging output from the RSDP parsing code can be
> visible and collected.
> 
> Suggested-by: Dave Young <dyoung@...hat.com>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Baoquan He <bhe@...hat.com>
> Cc: Chao Fan <fanc.fnst@...fujitsu.com>
> Cc: Jun'ichi Nomura <j-nomura@...jp.nec.com>
> Cc: Kairui Song <kasong@...hat.com>
> Cc: kexec@...ts.infradead.org
> Cc: x86@...nel.org
> ---
>  arch/x86/boot/compressed/misc.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
> index c0d6c560df69..24e65a0f756d 100644
> --- a/arch/x86/boot/compressed/misc.c
> +++ b/arch/x86/boot/compressed/misc.c
> @@ -351,9 +351,6 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap,
>  	/* Clear flags intended for solely in-kernel use. */
>  	boot_params->hdr.loadflags &= ~KASLR_FLAG;
>  
> -	/* Save RSDP address for later use. */
> -	boot_params->acpi_rsdp_addr = get_rsdp_addr();
> -
>  	sanitize_boot_params(boot_params);
>  
>  	if (boot_params->screen_info.orig_video_mode == 7) {
> @@ -368,6 +365,14 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap,
>  	cols = boot_params->screen_info.orig_video_cols;
>  
>  	console_init();
> +
> +	/*
> +	 * Save RSDP address for later use. Have this after console_init()
> +	 * so that early debugging output from the RSDP parsing code can be
> +	 * collected.
> +	 */
> +	boot_params->acpi_rsdp_addr = get_rsdp_addr();
> +
>  	debug_putstr("early console in extract_kernel\n");

Thanks for making this. FWIW,

Reviewed-by: Baoquan He <bhe@...hat.com>