linux-kernel - Re: [PATCH] perf arm64: Fix mksyscalltbl when system kernel headers are ahead of the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.1905211632300.4243@Diego>
Date:   Tue, 21 May 2019 16:34:47 +0200 (CEST)
From:   Michael Petlan <mpetlan@...hat.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
cc:     Vitaly Chikunov <vt@...linux.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Hendrik Brueckner <brueckner@...ux.ibm.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Kim Phillips <kim.phillips@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Subject: Re: [PATCH] perf arm64: Fix mksyscalltbl when system kernel headers
 are ahead of the kernel

On Tue, 21 May 2019, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 21, 2019 at 06:02:03AM +0300, Vitaly Chikunov escreveu:
> > When a host system has kernel headers that are newer than a compiling
> > kernel, mksyscalltbl fails with errors such as:
> > 
> >   <stdin>: In function 'main':
> >   <stdin>:271:44: error: '__NR_kexec_file_load' undeclared (first use in this function)
> >   <stdin>:271:44: note: each undeclared identifier is reported only once for each function it appears in
> >   <stdin>:272:46: error: '__NR_pidfd_send_signal' undeclared (first use in this function)
> >   <stdin>:273:43: error: '__NR_io_uring_setup' undeclared (first use in this function)
> >   <stdin>:274:43: error: '__NR_io_uring_enter' undeclared (first use in this function)
> >   <stdin>:275:46: error: '__NR_io_uring_register' undeclared (first use in this function)
> >   tools/perf/arch/arm64/entry/syscalls//mksyscalltbl: line 48: /tmp/create-table-xvUQdD: Permission denied
> > 
> > mksyscalltbl is compiled with default host includes, but run with
> 
> It shouldn't :-\ So with this you're making it use the ones shipped in
> tools/include? Good, I'll test it, thanks!
> 
> - Arnaldo
> 

I've hit the issue too, this patch fixes it for me.
Tested.

Michael

> > compiling kernel tree includes, causing some syscall numbers being
> > undeclared.
> > 
> > Signed-off-by: Vitaly Chikunov <vt@...linux.org>
> > Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> > Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> > Cc: Hendrik Brueckner <brueckner@...ux.ibm.com>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: Jiri Olsa <jolsa@...hat.com>
> > Cc: Kim Phillips <kim.phillips@....com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
> > ---
> >  tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> > index c88fd32563eb..459469b7222c 100755
> > --- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> > +++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> > @@ -56,7 +56,7 @@ create_table()
> >  	echo "};"
> >  }
> >  
> > -$gcc -E -dM -x c  $input	       \
> > +$gcc -E -dM -x c -I $incpath/include/uapi $input \
> >  	|sed -ne 's/^#define __NR_//p' \
> >  	|sort -t' ' -k2 -nu	       \
> >  	|create_table
> > -- 
> > 2.11.0
> 
> -- 
> 
> - Arnaldo
>