[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190521150044.GA7098@ulmo>
Date: Tue, 21 May 2019 17:00:44 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Kishon Vijay Abraham I <kishon@...com>
Cc: Jon Hunter <jonathanh@...dia.com>, JC Kuo <jckuo@...dia.com>,
linux-tegra@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 1/3] dt-bindings: phy: tegra-xusb: List PLL power supplies
On Thu, Apr 25, 2019 at 05:34:42PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
>
> These power supplies provide power for various PLLs that are set up and
> driven by the XUSB pad controller. These power supplies were previously
> improperly added to the PCIe and XUSB controllers, but depending on the
> driver probe order, power to the PLLs will not be supplied soon enough
> and cause initialization to fail.
>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
> This was previously reviewed here:
>
> https://patchwork.ozlabs.org/patch/1077153/
>
> .../bindings/phy/nvidia,tegra124-xusb-padctl.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Hi Kishon,
do you have any comments on this series. It's fairly straightforward but
is required in order to make XUSB work properly on Jetson Nano for which
support was merged in v5.2-rc1.
Thanks,
Thierry
>
> diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
> index daedb15f322e..9fb682e47c29 100644
> --- a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
> +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
> @@ -42,6 +42,18 @@ Required properties:
> - reset-names: Must include the following entries:
> - "padctl"
>
> +For Tegra124:
> +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
> +- avdd-pll-erefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
> +- avdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 3.3 V.
> +
> +For Tegra210:
> +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
> +- avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
> +- dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V.
> +
> For Tegra186:
> - avdd-pll-erefeut-supply: UPHY brick and reference clock as well as UTMI PHY
> power supply. Must supply 1.8 V.
> --
> 2.21.0
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists