linux-kernel - Re: [PATCH] mtd: onenand_base: Avoid fall-through warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 May 2019 15:20:06 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Boris Brezillon <boris.brezillon@...labora.com>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        linux-mtd@...ts.infradead.org,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] mtd: onenand_base: Avoid fall-through warnings

On Wed, May 22, 2019 at 11:57:38PM +0200, Boris Brezillon wrote:
> All this look suspicious, and even if the fall through logic
> has no side effects in practice (which I'm still not sure is the case),
> I think it'd be better to explicitly set the flags that have
> to be set in each case statement and add breaks.

Yeah, totally agreed. :)

-- 
Kees Cook