lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 22 May 2019 17:30:12 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Kees Cook <keescook@...omium.org>,
        Boris Brezillon <boris.brezillon@...labora.com>
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        linux-mtd@...ts.infradead.org,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] mtd: onenand_base: Avoid fall-through warnings



On 5/22/19 5:20 PM, Kees Cook wrote:
> On Wed, May 22, 2019 at 11:57:38PM +0200, Boris Brezillon wrote:
>> All this look suspicious, and even if the fall through logic
>> has no side effects in practice (which I'm still not sure is the case),
>> I think it'd be better to explicitly set the flags that have
>> to be set in each case statement and add breaks.
> 
> Yeah, totally agreed. :)
> 

Thank you, Kees and Boris for the feedback. Some external opinions were
certainly much needed here.

I'll just wait for any comments from the MTD guys.

Thanks
--
Gustavo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ