linux-kernel - Re: [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d775c1ac-e0ff-919b-22d6-8e585149374c@suse.cz>
Date:   Wed, 22 May 2019 12:32:37 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     Johan Hovold <johan@...nel.org>
Cc:     Gen Zhang <blackgod016574@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty_io.c

On 22. 05. 19, 12:29, Johan Hovold wrote:
>> Sure, but can class_find_device return NULL in this tty case here?
> 
> Yes, it can and will and that's fine, not all ttys have a struct device
> (e.g. ptys). 

IOW, the code needs a comment, if anything.

thanks,
-- 
js
suse labs