lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 May 2019 23:21:47 -0400 From: Jarod Wilson <jarod@...hat.com> To: Mahesh Bandewar (महेश बंडेवार) <maheshb@...gle.com>, Jay Vosburgh <jay.vosburgh@...onical.com> Cc: linux-kernel@...r.kernel.org, Veaceslav Falico <vfalico@...il.com>, Andy Gospodarek <andy@...yhouse.net>, "David S. Miller" <davem@...emloft.net>, linux-netdev <netdev@...r.kernel.org>, Heesoon Kim <Heesoon.Kim@...atus.com> Subject: Re: [PATCH net] bonding/802.3ad: fix slave link initialization transition states On 5/24/19 6:38 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Fri, May 24, 2019 at 2:17 PM Jay Vosburgh <jay.vosburgh@...onical.com> wrote: >> >> Jarod Wilson <jarod@...hat.com> wrote: >> >>> Once in a while, with just the right timing, 802.3ad slaves will fail to >>> properly initialize, winding up in a weird state, with a partner system >>> mac address of 00:00:00:00:00:00. This started happening after a fix to >>> properly track link_failure_count tracking, where an 802.3ad slave that >>> reported itself as link up in the miimon code, but wasn't able to get a >>> valid speed/duplex, started getting set to BOND_LINK_FAIL instead of >>> BOND_LINK_DOWN. That was the proper thing to do for the general "my link >>> went down" case, but has created a link initialization race that can put >>> the interface in this odd state. >> > Are there any notification consequences because of this change? No, there shouldn't be, it just makes initial link-up cleaner, everything during runtime once the link is initialized should remain the same. -- Jarod Wilson jarod@...hat.com
Powered by blists - more mailing lists