linux-kernel - Re: [PATCH] drivers: base: power: Use of_clk_get_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdX=o+gT6fbpZcj8jQbHi9LJci9CX72DG5j+DKYxuSkYvQ@mail.gmail.com>
Date:   Mon, 27 May 2019 13:08:05 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: base: power: Use of_clk_get_parent_count()

Hi Kefeng,

On Sat, May 25, 2019 at 1:54 PM Kefeng Wang <wangkefeng.wang@...wei.com> wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>

Thanks for your patch!

> --- a/drivers/base/power/clock_ops.c
> +++ b/drivers/base/power/clock_ops.c
> @@ -195,8 +195,7 @@ int of_pm_clk_add_clks(struct device *dev)
>         if (!dev || !dev->of_node)
>                 return -EINVAL;
>
> -       count = of_count_phandle_with_args(dev->of_node, "clocks",
> -                                          "#clock-cells");
> +       count = of_clk_get_parent_count(dev->of_node);
>         if (count <= 0)
>                 return -ENODEV;


Given of_clk_get_parent_count() is provided by <linux/of_clk.h>, I think
you should add an include for that.

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds