linux-kernel - Re: [PATCH] kconfig: tests: fix recursive inclusion unit test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATQCpNp4azKE4YJDpC-gSTRBYe6Lj7dTX+1N=7iqKsMXw@mail.gmail.com>
Date:   Tue, 28 May 2019 09:34:46 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kconfig: tests: fix recursive inclusion unit test

On Sat, May 25, 2019 at 8:49 PM Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> Adding SPDX license identifier is pretty safe; however, here is one
> exception.
>
> Since commit ec8f24b7faaf ("treewide: Add SPDX license identifier -
> Makefile/Kconfig"), "make testconfig" would not pass.
>
> When Kconfig detects a circular file inclusion, it displays error
> messages with a file name and a line number prefixed to each line.
>
> The unit test checks if Kconfig emits the error messages correctly
> (this also checks the line number correctness).
>
> Now that the test input has the SPDX license identifier at the very top,
> the line numbers in the expected stderr should be incremented by 1.
>
> Fixes: ec8f24b7faaf ("treewide: Add SPDX license identifier - Makefile/Kconfig")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---

Applied to linux-kbuild/fixes.


>
>  scripts/kconfig/tests/err_recursive_inc/expected_stderr | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/kconfig/tests/err_recursive_inc/expected_stderr b/scripts/kconfig/tests/err_recursive_inc/expected_stderr
> index 6b582eee2176..b070a31fdfeb 100644
> --- a/scripts/kconfig/tests/err_recursive_inc/expected_stderr
> +++ b/scripts/kconfig/tests/err_recursive_inc/expected_stderr
> @@ -1,6 +1,6 @@
>  Recursive inclusion detected.
>  Inclusion path:
>    current file : Kconfig.inc1
> -  included from: Kconfig.inc3:1
> -  included from: Kconfig.inc2:3
> -  included from: Kconfig.inc1:4
> +  included from: Kconfig.inc3:2
> +  included from: Kconfig.inc2:4
> +  included from: Kconfig.inc1:5
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada