linux-kernel - Re: [PATCH] Revert "usb: dwc2: host: Setting qtd to NULL after freeing it"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=WaWf51QTzPAv68e8m-WZ287E63M_y2G=dVmowh91p9jg@mail.gmail.com>
Date:   Wed, 29 May 2019 14:00:41 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Minas Harutyunyan <hminas@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Vardan Mikayelyan <mvardan@...opsys.com>,
        John Youn <johnyoun@...opsys.com>,
        Douglas Anderson <dianders@...omiun.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
Subject: Re: [PATCH] Revert "usb: dwc2: host: Setting qtd to NULL after
 freeing it"

Hi,

On Wed, May 29, 2019 at 1:54 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> This reverts commit b0d659022e5c96ee5c4bd62d22d3da2d66de306b.
>
> The reverted commit does nothing but adding two unnecessary lines
> of code.  It sets a local variable to NULL in two functions, but
> that variable is not used anywhere in the rest of those functions.
> This is just confusing, so let's remove it.
>
> Cc: Vardan Mikayelyan <mvardan@...opsys.com>
> Cc: John Youn <johnyoun@...opsys.com>
> Cc: Douglas Anderson <dianders@...omiun.org>
> Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/usb/dwc2/hcd.c | 1 -
>  drivers/usb/dwc2/hcd.h | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Douglas Anderson <dianders@...omium.org>