linux-kernel - Re: [PATCH] Revert "usb: dwc2: host: Setting qtd to NULL after freeing it"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 May 2019 18:21:34 +0400
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        John Youn <John.Youn@...opsys.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
Subject: Re: [PATCH] Revert "usb: dwc2: host: Setting qtd to NULL after
 freeing it"

On 5/30/2019 12:55 AM, Guenter Roeck wrote:
> This reverts commit b0d659022e5c96ee5c4bd62d22d3da2d66de306b.
> 
> The reverted commit does nothing but adding two unnecessary lines
> of code.  It sets a local variable to NULL in two functions, but
> that variable is not used anywhere in the rest of those functions.
> This is just confusing, so let's remove it.
> 
> Cc: Vardan Mikayelyan <mvardan@...opsys.com>
> Cc: John Youn <johnyoun@...opsys.com>
> Cc: Douglas Anderson <dianders@...omiun.org>
> Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Acked-by: Minas Harutyunyan <hminas@...opsys.com>


> ---
>   drivers/usb/dwc2/hcd.c | 1 -
>   drivers/usb/dwc2/hcd.h | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index b50ec3714fd8..bca64b0d4d15 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -4676,7 +4676,6 @@ static int _dwc2_hcd_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
>   	spin_unlock_irqrestore(&hsotg->lock, flags);
>   	urb->hcpriv = NULL;
>   	kfree(qtd);
> -	qtd = NULL;
>   fail1:
>   	if (qh_allocated) {
>   		struct dwc2_qtd *qtd2, *qtd2_tmp;
> diff --git a/drivers/usb/dwc2/hcd.h b/drivers/usb/dwc2/hcd.h
> index c089ffa1f0a8..f6bc48432b04 100644
> --- a/drivers/usb/dwc2/hcd.h
> +++ b/drivers/usb/dwc2/hcd.h
> @@ -574,7 +574,6 @@ static inline void dwc2_hcd_qtd_unlink_and_free(struct dwc2_hsotg *hsotg,
>   {
>   	list_del(&qtd->qtd_list_entry);
>   	kfree(qtd);
> -	qtd = NULL;
>   }
>   
>   /* Descriptor DMA support functions */
>