linux-kernel - Re: [PATCH] crypto: gcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu8jJQCZwiHFORUJUzRaAizWzBQ95EAgYe36sFrcvzb6vg@mail.gmail.com>
Date:   Thu, 30 May 2019 16:28:54 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Iuliana Prodan <iuliana.prodan@....com>,
        Eric Biggers <ebiggers@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Horia Geanta <horia.geanta@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] crypto: gcm - fix cacheline sharing

On Thu, 30 May 2019 at 16:27, Herbert Xu <herbert@...dor.apana.org.au> wrote:
>
> On Thu, May 30, 2019 at 03:55:07PM +0200, Ard Biesheuvel wrote:
> >
> > > Would this work?
>
> I see.  You need to preserve the original IV.
>
> > > diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c
> > > index c0ece44f303b..2ef2f76a3cb8 100644
> > > --- a/drivers/crypto/caam/caamalg.c
> > > +++ b/drivers/crypto/caam/caamalg.c
> > > @@ -1832,22 +1832,25 @@ static int skcipher_decrypt(struct
> > > skcipher_request *req)
> > >         struct caam_ctx *ctx = crypto_skcipher_ctx(skcipher);
> > >         int ivsize = crypto_skcipher_ivsize(skcipher);
> > >         struct device *jrdev = ctx->jrdev;
> > > +       u8 out_iv[AES_BLOCK_SIZE];
> > >         u32 *desc;
> > >         int ret = 0;
> > >
> > > -       /* allocate extended descriptor */
> > > -       edesc = skcipher_edesc_alloc(req, DESC_JOB_IO_LEN * CAAM_CMD_SZ);
> > > -       if (IS_ERR(edesc))
> > > -               return PTR_ERR(edesc);
> > > -
> > >         /*
> > >          * The crypto API expects us to set the IV (req->iv) to the last
> > >          * ciphertext block.
> > >          */
> > >         if (ivsize)
> > > -               scatterwalk_map_and_copy(req->iv, req->src, req->cryptlen -
> > > +               scatterwalk_map_and_copy(out_iv, req->src, req->cryptlen -
> > >                                          ivsize, ivsize, 0);
> > >
> > > +       /* allocate extended descriptor */
> > > +       edesc = skcipher_edesc_alloc(req, DESC_JOB_IO_LEN * CAAM_CMD_SZ);
> > > +       if (IS_ERR(edesc))
> > > +               return PTR_ERR(edesc);
> > > +
> > > +       memcpy(req->iv, out_iv, ivsize);
> > > +
> > >         /* Create and submit job descriptor*/
> > >         init_skcipher_job(req, edesc, false);
> > >         desc = edesc->hw_desc;
> >
> > Umm never mind
> >
> > /me hides in shame
>
> So why doesn't this work?
>

Because the memcpy() occurs while the buffer is mapped for DMA, so it
suffers from the exact same problem.