linux-kernel - Re: [PATCH bpf-next 5/5] bpf: move memory size checks to bpf_map_charge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190530190928.GD4855@tower.DHCP.thefacebook.com>
Date:   Thu, 30 May 2019 19:09:32 +0000
From:   Roman Gushchin <guro@...com>
To:     Song Liu <liu.song.a23@...il.com>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        bpf <bpf@...r.kernel.org>, Kernel Team <Kernel-team@...com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next 5/5] bpf: move memory size checks to
 bpf_map_charge_init()

On Thu, May 30, 2019 at 11:56:55AM -0700, Song Liu wrote:
> On Wed, May 29, 2019 at 6:05 PM Roman Gushchin <guro@...com> wrote:
> >
> > Most bpf map types doing similar checks and bytes to pages
> > conversion during memory allocation and charging.
> >
> > Let's unify these checks by moving them into bpf_map_charge_init().
> >
> > Signed-off-by: Roman Gushchin <guro@...com>
> 
> Nice, I was thinking about similar issues while reading patches
> 3/5 and 4/5. I really like this simplification.
> 
> Acked-by: Song Liu <songliubraving@...com>

Thank you for the review, Song!