linux-kernel - Re: [PATCH] PM / clk: Remove error message on out-of-memory condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4033832.t2mNCoI3x2@kreacher>
Date:   Fri, 31 May 2019 11:29:16 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / clk: Remove error message on out-of-memory condition

On Monday, May 27, 2019 2:27:51 PM CEST Geert Uytterhoeven wrote:
> There is no need to print an error message if kstrdup() fails, as the
> memory allocation core already takes care of that.
> 
> Note that commit 59d84ca8c46a93ad ("PM / OPP / clk: Remove unnecessary
> OOM message") already removed similar error messages, but this one was
> forgotten.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/base/power/clock_ops.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
> index 59d19dd649289287..1cf86fcaeff8faac 100644
> --- a/drivers/base/power/clock_ops.c
> +++ b/drivers/base/power/clock_ops.c
> @@ -92,8 +92,6 @@ static int __pm_clk_add(struct device *dev, const char *con_id,
>  	if (con_id) {
>  		ce->con_id = kstrdup(con_id, GFP_KERNEL);
>  		if (!ce->con_id) {
> -			dev_err(dev,
> -				"Not enough memory for clock connection ID.\n");
>  			kfree(ce);
>  			return -ENOMEM;
>  		}
> 

Applied, thanks!