linux-kernel - Re: [PATCH] staging: rtl8712: Replace function r8712_init_mlme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190531092907.GC31203@kadam>
Date:   Fri, 31 May 2019 12:29:07 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>
Cc:     larry.finger@...inger.net, florian.c.schilhabel@...glemail.com,
        gregkh@...uxfoundation.org, himadri18.07@...il.com,
        colin.king@...onical.com, straube.linux@...il.com,
        yangx92@...mail.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Replace function r8712_init_mlme_priv

On Fri, May 31, 2019 at 02:25:31AM +0530, Nishka Dasgupta wrote:
> Delete r8712_init_mlme_priv as it does nothing except call
> _init_mlme_priv, and rename _init_mlme_priv to
> r8712_init_mlme_priv.
> Change the type of the new r8712_init_mlme_priv (formerly _init_mlme_priv)
> to (non-static) int, from static sint.
> 
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@...il.com>
> ---

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

Looks good, thanks.

regards,
dan carpenter