linux-kernel - Re: [PATCH v2 5/9] staging: rtl8712: Fixed CamelCase renames IsrContent to isr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Jun 2019 19:13:00 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Deepak Mishra <linux.dkm@...il.com>
Cc:     linux-kernel@...r.kernel.org, joe@...ches.com, wlanfae@...ltek.com,
        Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        himadri18.07@...il.com, straube.linux@...il.com
Subject: Re: [PATCH v2 5/9] staging: rtl8712: Fixed CamelCase renames
 IsrContent to isr_content

On Sun, Jun 02, 2019 at 03:55:34PM +0530, Deepak Mishra wrote:
> This patch fixes CamelCase IsrContent to isr_content as suggested by
> checkpatch.pl
> 
> Signed-off-by: Deepak Mishra <linux.dkm@...il.com>
> ---
>  drivers/staging/rtl8712/drv_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 5360f049088a..a5060a020b2b 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -148,7 +148,7 @@ struct _adapter {
>  	bool	driver_stopped;
>  	bool	surprise_removed;
>  	bool	suspended;
> -	u32	IsrContent;
> +	u32	isr_content;
>  	u32	imr_content;
>  	u8	eeprom_address_size;
>  	u8	hw_init_completed;

Same comment here, just remove unused variables.  Is this structure even
ever used anywhere?

thanks,

greg k-h