linux-kernel - Re: [PATCH v2 6/9] staging: rtl8712: Fixed CamelCase renames xmitThread and recvThread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190602171326.GD19671@kroah.com>
Date:   Sun, 2 Jun 2019 19:13:26 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Deepak Mishra <linux.dkm@...il.com>
Cc:     linux-kernel@...r.kernel.org, joe@...ches.com, wlanfae@...ltek.com,
        Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        himadri18.07@...il.com, straube.linux@...il.com
Subject: Re: [PATCH v2 6/9] staging: rtl8712: Fixed CamelCase renames
 xmitThread and recvThread

On Sun, Jun 02, 2019 at 03:55:35PM +0530, Deepak Mishra wrote:
> This patch fixes CamelCase as reported by checkpatch.pl
> xmitThread renamed to xmit_thread
> recvThread renamed to recv_thread
> 
> Signed-off-by: Deepak Mishra <linux.dkm@...il.com>
> ---
>  drivers/staging/rtl8712/drv_types.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index a5060a020b2b..1f8aa0358b77 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -154,8 +154,8 @@ struct _adapter {
>  	u8	hw_init_completed;
>  	struct task_struct *cmd_thread;
>  	pid_t evt_thread;
> -	struct task_struct *xmitThread;
> -	pid_t recvThread;
> +	struct task_struct *xmit_thread;
> +	pid_t recv_thread;
>  	uint (*dvobj_init)(struct _adapter *adapter);
>  	void (*dvobj_deinit)(struct _adapter *adapter);
>  	struct net_device *pnetdev;

Again, please just remove the fields entirely.

thanks,

greg k-h