linux-kernel - RE: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB3916D2B09BACABB79E8989A2F5140@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Mon, 3 Jun 2019 07:39:16 +0000
From:   Anson Huang <anson.huang@....com>
To:     Abel Vesa <abel.vesa@....com>
CC:     "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "maxime.ripard@...tlin.com" <maxime.ripard@...tlin.com>,
        "olof@...om.net" <olof@...om.net>,
        "horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
        "jagan@...rulasolutions.com" <jagan@...rulasolutions.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        Leonard Crestez <leonard.crestez@....com>,
        "dinguyen@...nel.org" <dinguyen@...nel.org>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        Aisheng Dong <aisheng.dong@....com>,
        Jacky Bai <ping.bai@....com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver

Hi, Abel

> -----Original Message-----
> From: Abel Vesa
> Sent: Monday, June 3, 2019 3:30 PM
> To: Anson Huang <anson.huang@....com>
> Cc: mturquette@...libre.com; sboyd@...nel.org; robh+dt@...nel.org;
> mark.rutland@....com; shawnguo@...nel.org; s.hauer@...gutronix.de;
> kernel@...gutronix.de; festevam@...il.com; catalin.marinas@....com;
> will.deacon@....com; maxime.ripard@...tlin.com; olof@...om.net;
> horms+renesas@...ge.net.au; jagan@...rulasolutions.com;
> bjorn.andersson@...aro.org; Leonard Crestez <leonard.crestez@....com>;
> dinguyen@...nel.org; enric.balletbo@...labora.com; Aisheng Dong
> <aisheng.dong@....com>; Jacky Bai <ping.bai@....com>;
> l.stach@...gutronix.de; linux-clk@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver
> 
> On 19-06-03 09:35:02, Anson.Huang@....com wrote:
> > From: Anson Huang <Anson.Huang@....com>
> >
> > This patch adds i.MX8MN clock driver support.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> > Changes since V1:
> > 	- add GPIOx clocks.
> 
> ...
> 
> > +static struct imx_pll14xx_clk imx8mn_sys_pll __initdata = {
> > +		.type = PLL_1416X,
> > +		.rate_table = imx8mn_pll1416x_tbl,
> > +};
> > +
> > +static const char *pll_ref_sels[] = { "osc_24m", "dummy", "dummy",
> > +"dummy", };
> 
> All of these should be "static const char * const ".

OK.

> 
> > +static const char *audio_pll1_bypass_sels[] = {"audio_pll1",
> > +"audio_pll1_ref_sel", }; static const char *audio_pll2_bypass_sels[]
> > += {"audio_pll2", "audio_pll2_ref_sel", };
> 
> ...
> 
> > +	clk_data.clks = clks;
> > +	clk_data.clk_num = ARRAY_SIZE(clks);
> > +	ret = of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data);
> > +	if (ret < 0) {
> > +		pr_err("failed to register clks for i.MX8MN\n");
> > +		return -EINVAL;
> > +	}
> > +
> > +	imx_register_uart_clocks(uart_clks);
> > +
> > +	return 0;
> > +}
> > +CLK_OF_DECLARE_DRIVER(imx8mn, "fsl,imx8mn-ccm",
> imx8mn_clocks_init);
> 
> Any reason why this cannot be a platform driver ?

It should can be, I just did NOT take care of it, 8MQ uses platform driver model, while
8MM does NOT, I will modify both of them to use platform driver model.

Thanks,
Anson.

> 
> > --
> > 2.7.4
> >