linux-kernel - Re: [PATCH -next] scsi: lpfc: Make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9a78d2a-a756-c42e-0c8d-af8ebf262615@broadcom.com>
Date:   Tue, 4 Jun 2019 10:36:55 -0700
From:   James Smart <james.smart@...adcom.com>
To:     YueHaibing <yuehaibing@...wei.com>, dick.kennedy@...adcom.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com,
        jsmart2021@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH -next] scsi: lpfc: Make some symbols static



On 5/31/2019 8:28 AM, YueHaibing wrote:
> Fix sparse warnings:
>
> drivers/scsi/lpfc/lpfc_sli.c:115:1: warning: symbol 'lpfc_sli4_pcimem_bcopy' was not declared. Should it be static?
> drivers/scsi/lpfc/lpfc_sli.c:7854:1: warning: symbol 'lpfc_sli4_process_missed_mbox_completions' was not declared. Should it be static?
> drivers/scsi/lpfc/lpfc_nvmet.c:223:27: warning: symbol 'lpfc_nvmet_get_ctx_for_xri' was not declared. Should it be static?
> drivers/scsi/lpfc/lpfc_nvmet.c:245:27: warning: symbol 'lpfc_nvmet_get_ctx_for_oxid' was not declared. Should it be static?
> drivers/scsi/lpfc/lpfc_init.c:75:10: warning: symbol 'lpfc_present_cpu' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/scsi/lpfc/lpfc_init.c  | 2 +-
>   drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++--
>   drivers/scsi/lpfc/lpfc_sli.c   | 4 ++--
>   3 files changed, 5 insertions(+), 5 deletions(-)
>
>

Looks good - thank You

Reviewed-by: James Smart  <james.smart@...adcom.com>