linux-kernel - Re: [PATCH RESEND 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190605060944.GB29853@dragon>
Date:   Wed, 5 Jun 2019 14:09:45 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Anson.Huang@....com
Cc:     s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        leonard.crestez@....com, abel.vesa@....com,
        viresh.kumar@...aro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, hyc.nju@...il.com, Linux-imx@....com
Subject: Re: [PATCH RESEND 1/2] soc: imx: soc-imx8: Avoid unnecessary
 of_node_put() in error handling

On Fri, May 24, 2019 at 01:51:00PM +0800, Anson.Huang@....com wrote:
> From: Anson Huang <Anson.Huang@....com>
> 
> of_node_put() is called after of_match_node() successfully called,
> then in the following error handling, of_node_put() is called again
> which is unnecessary, this patch adjusts the location of of_node_put()
> to avoid such scenario.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> Reviewed-by: Leonard Crestez <leonard.crestez@....com>

Applied both, thanks.