lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 5 Jun 2019 06:09:12 +0000
From:   Anson Huang <anson.huang@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Aisheng Dong <aisheng.dong@....com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        Daniel Baluta <daniel.baluta@....com>,
        Peng Fan <peng.fan@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH RESEND V4 2/3] arm64: dts: imx8qxp: Move watchdog node
 into scu node

Hi, Shawn

> -----Original Message-----
> From: Shawn Guo <shawnguo@...nel.org>
> Sent: Wednesday, June 5, 2019 2:00 PM
> To: Anson Huang <anson.huang@....com>
> Cc: robh+dt@...nel.org; mark.rutland@....com; wim@...ux-watchdog.org;
> linux@...ck-us.net; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; Aisheng Dong <aisheng.dong@....com>;
> ulf.hansson@...aro.org; Daniel Baluta <daniel.baluta@....com>; Peng Fan
> <peng.fan@....com>; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-watchdog@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH RESEND V4 2/3] arm64: dts: imx8qxp: Move watchdog
> node into scu node
> 
> On Tue, Jun 04, 2019 at 09:06:28AM +0000, Anson Huang wrote:
> > Hi, Shawn
> > 	The driver and binding doc are already reviewed and waiting for DT
> patch, will you help review this DT patch?
> 
> I'm fine with it.  Should I just pick this patch up, or is there any dependency
> we need to handle?

No dependency, it just makes more sense to move the node into SCU node as it is NOW depending on SCU
driver. Once you pick up this patch (and maybe the dt-binding patch as well?), I will notify the watchdog
maintainer to pick up the watchdog patch in this series.

Thanks,
Anson

> 
> Shawn
> 
> >
> > Thanks,
> > Anson
> >
> > > -----Original Message-----
> > > From: Anson Huang
> > > Sent: Sunday, May 12, 2019 6:11 PM
> > > To: robh+dt@...nel.org; mark.rutland@....com;
> > > wim@...ux-watchdog.org; linux@...ck-us.net; shawnguo@...nel.org;
> > > s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
> > > Aisheng Dong <aisheng.dong@....com>; ulf.hansson@...aro.org; Daniel
> > > Baluta <daniel.baluta@....com>; Peng Fan <peng.fan@....com>;
> > > devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> > > watchdog@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> > > Cc: dl-linux-imx <linux-imx@....com>
> > > Subject: [PATCH RESEND V4 2/3] arm64: dts: imx8qxp: Move watchdog
> > > node into scu node
> > >
> > > i.MX system controller watchdog has pretimeout function which
> > > depends on i.MX SCU driver, so it should be a subnode of SCU.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > > ---
> > > No change, just resend patch with correct encoding.
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 10 +++++-----
> > >  1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > index 0683ee2..b17c22e 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > @@ -149,6 +149,11 @@
> > >  		rtc: rtc {
> > >  			compatible = "fsl,imx8qxp-sc-rtc";
> > >  		};
> > > +
> > > +		watchdog {
> > > +			compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
> > > +			timeout-sec = <60>;
> > > +		};
> > >  	};
> > >
> > >  	timer {
> > > @@ -517,9 +522,4 @@
> > >  			power-domains = <&pd IMX_SC_R_GPIO_7>;
> > >  		};
> > >  	};
> > > -
> > > -	watchdog {
> > > -		compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
> > > -		timeout-sec = <60>;
> > > -	};
> > >  };
> > > --
> > > 2.7.4
> >

Powered by blists - more mailing lists