linux-kernel - [PATCH] kbuild: s390, do not remove autogenerated headers on clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190605111416.13341-1-jslaby@suse.cz>
Date:   Wed,  5 Jun 2019 13:14:16 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     heiko.carstens@...ibm.com
Cc:     linux-kernel@...r.kernel.org, Jiri Slaby <jslaby@...e.cz>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kbuild@...r.kernel.org, Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: [PATCH] kbuild: s390, do not remove autogenerated headers on clean

'make clean' does NOT remove autogenerated headers generated from
arch/s390/kernel/syscalls/. For example:
asm-offsets.h
irq_regs.h
irq_work.h
unistd_nr.h

But 'make clean' DOES currently remove dis-defs.h and facility-defs.h
generated from arch/s390/tools/.

The issue is that facility-defs.h is included from <asm/facility.h> and
builds of external modules fail due to missing header. (When cleaned
build directory is used.)

Fix this by adding these targets to no-clean-files.

Signed-off-by: Jiri Slaby <jslaby@...e.cz>
Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: Michal Marek <michal.lkml@...kovi.net>
Cc: linux-kbuild@...r.kernel.org
Cc: Heiko Carstens <heiko.carstens@...ibm.com>
Cc: Vasily Gorbik <gor@...ux.ibm.com>
Cc: Christian Borntraeger <borntraeger@...ibm.com>
Cc: linux-s390@...r.kernel.org
---

I would love to see comments from KBuild guys as I am not sure if this
fix is correct at all.

 arch/s390/tools/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
index 2342b84b3386..984b2f43651e 100644
--- a/arch/s390/tools/Makefile
+++ b/arch/s390/tools/Makefile
@@ -7,6 +7,7 @@ kapi := arch/$(ARCH)/include/generated/asm
 kapi-hdrs-y := $(kapi)/facility-defs.h $(kapi)/dis-defs.h
 
 targets += $(addprefix ../../../,$(kapi-hdrs-y))
+no-clean-files += $(targets)
 PHONY += kapi
 
 kapi:	$(kapi-hdrs-y)
-- 
2.21.0