linux-kernel - Re: [PATCH] kbuild: s390, do not remove autogenerated headers on clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQxW9x1mVa742vD7-NJuUNh=pTNqfT8BRUt=hs_7EiE2w@mail.gmail.com>
Date:   Wed, 5 Jun 2019 20:29:06 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Heiko Carstens <heiko.carstens@...ibm.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390 <linux-s390@...r.kernel.org>
Subject: Re: [PATCH] kbuild: s390, do not remove autogenerated headers on clean

On Wed, Jun 5, 2019 at 8:14 PM Jiri Slaby <jslaby@...e.cz> wrote:
>
> 'make clean' does NOT remove autogenerated headers generated from
> arch/s390/kernel/syscalls/. For example:
> asm-offsets.h
> irq_regs.h
> irq_work.h
> unistd_nr.h
>
> But 'make clean' DOES currently remove dis-defs.h and facility-defs.h
> generated from arch/s390/tools/.
>
> The issue is that facility-defs.h is included from <asm/facility.h> and
> builds of external modules fail due to missing header. (When cleaned
> build directory is used.)
>
> Fix this by adding these targets to no-clean-files.
>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Cc: Michal Marek <michal.lkml@...kovi.net>
> Cc: linux-kbuild@...r.kernel.org
> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: linux-s390@...r.kernel.org
> ---
>
> I would love to see comments from KBuild guys as I am not sure if this
> fix is correct at all.


This issue had already been fixed by the side-effect of
another patch, which is in linux-next.



See this:


commit 10077c9f2dae1afabab2808a0326ecf3e8e5a82c
Author: Masahiro Yamada <yamada.masahiro@...ionext.com>
Date:   Fri May 17 16:54:27 2019 +0900

    s390: drop meaningless 'targets' from tools Makefile

    'targets' should be specified to include .*.cmd files to evaluate
    if_changed or friends.

    Here, facility-defs.h and dis-defs.h are generated by filechk.

    Because filechk does not generate .*.cmd file, the 'targets' addition
    is meaningless. The filechk correctly updates the target when its
    content is changed.

    Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
    Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>


Thanks.


-- 
Best Regards
Masahiro Yamada