lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 7 Jun 2019 08:29:08 +0800
From:   tanhuazhong <tanhuazhong@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <linuxarm@...wei.com>, <tanxiaofei@...wei.com>
Subject: Re: [PATCH net-next 01/12] net: hns3: log detail error info of ROCEE
 ECC and AXI errors



On 2019/6/7 1:36, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@...wei.com>
> Date: Thu, 6 Jun 2019 16:20:56 +0800
> 
>> +static int hclge_log_rocee_axi_error(struct hclge_dev *hdev)
>> +{
>   ...
>> +	ret = hclge_cmd_send(&hdev->hw, &desc[0], 3);
>> +	if (ret) {
>> +		dev_err(dev, "failed(%d) to query ROCEE AXI error sts\n", ret);
>> +		return ret;
>> +	}
>   ...
>> +		ret = hclge_log_rocee_axi_error(hdev);
>> +		if (ret) {
>> +			dev_err(dev, "failed(%d) to process axi error\n", ret);
> 
> You log the error twice which is unnecessary.
> 

ok, thanks.

> .
> 

Powered by blists - more mailing lists