linux-kernel - RE: [PATCH v7 1/6] dt-bindings: add binding for USBSS-DRD controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR07MB470915AB1D833EC1CEA5C8D7DD130@BYAPR07MB4709.namprd07.prod.outlook.com>
Date:   Mon, 10 Jun 2019 06:45:48 +0000
From:   Pawel Laszczak <pawell@...ence.com>
To:     Peter Chen <peter.chen@....com>, Roger Quadros <rogerq@...com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jbergsagel@...com" <jbergsagel@...com>,
        "nsekhar@...com" <nsekhar@...com>, "nm@...com" <nm@...com>,
        Suresh Punnoose <sureshp@...ence.com>,
        Jayshri Dajiram Pawar <jpawar@...ence.com>,
        Rahul Kumar <kurahul@...ence.com>
Subject: RE: [PATCH v7 1/6] dt-bindings: add binding for USBSS-DRD controller.

>
>>  - reg-names - register memory area names:
>>         "xhci" - for HOST registers space
>>         "dev" - for DEVICE registers space
>>         "otg" - for OTG/DRD registers space
>>  - compatible: Should contain:
>>         "cdns,usb3-1.0.0" - for 0x00024502 controller version
>>         "cdns,usb3-1.0.1" - for 0x00024509 controller version
>>         "cdns,usb3-1.0.2" - for 0x0002450C controller version
>>         "cdns,usb3-1.0.3" - for 0x0002450d controller version
>
>If the value can be read from register, why we still need different compatibles?
We don't need it. I left it only  as information that cdns3 controller exist in 4 different version. 

>
>> Example:
>>         usb@...00000 {
>>                 compatible = "cdns,usb3-1.0.1";
>>                 interrupts = <GIC_USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>,
>>                                 <GIC_USB_IRQ  7 IRQ_TYPE_LEVEL_HIGH>,
>>                                 <GIC_USB_IRQ  8 IRQ_TYPE_LEVEL_HIGH>;
>>                 interrupt-names = "host", "peripheral", "otg";
>>                 reg = <0xf3000000 0x10000>,     /* memory area for HOST registers */
>>                         <0xf3010000 0x10000>,   /* memory area for DEVICE registers */
>>                         <0xf3020000 0x10000>;   /* memory area for OTG/DRD registers
>> */
>>                 reg-names = "xhci", "dev", "otg";
>>                 phys = <&usb3_phy>;
>>                 phy-names = "cdns3,usbphy";
>>
>>
>> Maybe I should add also something for usb2_phy in dt-binding and in driver ?
>>
>
>The PHY driver is located at: drivers/phy/cadence/phy-cadence-sierra.c.
>Will we need another one for USB2 PHY?

As I know sierra phy is USB3.0 phy. 
Also I know that we have torent phy driver for 2.0. It's ready but is has not yet in kernel. 
So I assume that I should change
              phys = <&usb3_phy>;
              phy-names = "cdns3,usbphy";

with: 
                 phys = <&usb2_phy>, <&usb3_phy>;
                 phy-names = "cdns3,usbphy2", "cdns3,usbphy3";

Pawel
>
>Peter
>
>
>> Thanks,
>> Regards,
>> Pawel
>>
>> >>
>> >> Regards,
>> >> Pawel
>> >>
>> >>
>> >>>
>> >>>> +
>> >>>> +Optional properties:
>> >>>> + - maximum-speed : valid arguments are "super-speed", "high-speed" and
>> >>>> +                   "full-speed"; refer to usb/generic.txt
>> >>>> + - dr_mode: Should be one of "host", "peripheral" or "otg".
>> >>>> + - phys: reference to the USB PHY
>> >>>> +
>> >>>> +Example:
>> >>>> +	usb@...00000 {
>> >>>> +		compatible = "cdns,usb3-1.0.1";
>> >>>> +		interrupts = <USB_IRQ  7 IRQ_TYPE_LEVEL_HIGH>;
>> >>>
>> >>> This example won't work as code requests for 3 separate interrupts.
>> >>>
>> >>>> +		reg = <0xf3000000 0x10000	/* memory area for HOST
>> registers */
>> >>>> +			0xf3010000 0x10000	/* memory area for DEVICE
>> registers */
>> >>>> +			0xf3020000 0x10000>;	/* memory area for
>> OTG/DRD registers */
>> >>>> +		reg-names = "xhci", "dev", "otg";
>> >>>> +	};
>> >>>>
>> >>>
>> >
>> >
>> >--
>> >cheers,
>> >-roger
>> >
>> >Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
>> >Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki