linux-kernel - RE: [PATCH v7 1/6] dt-bindings: add binding for USBSS-DRD controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB5327D364DC5930C3A954AA6A8B130@VI1PR04MB5327.eurprd04.prod.outlook.com>
Date:   Mon, 10 Jun 2019 06:52:44 +0000
From:   Peter Chen <peter.chen@....com>
To:     Pawel Laszczak <pawell@...ence.com>, Roger Quadros <rogerq@...com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jbergsagel@...com" <jbergsagel@...com>,
        "nsekhar@...com" <nsekhar@...com>, "nm@...com" <nm@...com>,
        Suresh Punnoose <sureshp@...ence.com>,
        Jayshri Dajiram Pawar <jpawar@...ence.com>,
        Rahul Kumar <kurahul@...ence.com>
Subject: RE: [PATCH v7 1/6] dt-bindings: add binding for USBSS-DRD controller.


 
> >>  - reg-names - register memory area names:
> >>         "xhci" - for HOST registers space
> >>         "dev" - for DEVICE registers space
> >>         "otg" - for OTG/DRD registers space
> >>  - compatible: Should contain:
> >>         "cdns,usb3-1.0.0" - for 0x00024502 controller version
> >>         "cdns,usb3-1.0.1" - for 0x00024509 controller version
> >>         "cdns,usb3-1.0.2" - for 0x0002450C controller version
> >>         "cdns,usb3-1.0.3" - for 0x0002450d controller version
> >
> >If the value can be read from register, why we still need different compatibles?
> We don't need it. I left it only  as information that cdns3 controller exist in 4 different
> version.
> 

So, you will have only one compatible at both driver and binding doc, eg "cdns, usb3"?
And you may move the controller information into the driver, and have a MACRO for it?

> >> Maybe I should add also something for usb2_phy in dt-binding and in driver ?
> >>
> >
> >The PHY driver is located at: drivers/phy/cadence/phy-cadence-sierra.c.
> >Will we need another one for USB2 PHY?
> 
> As I know sierra phy is USB3.0 phy.
> Also I know that we have torent phy driver for 2.0. It's ready but is has not yet in
> kernel.
> So I assume that I should change
>               phys = <&usb3_phy>;
>               phy-names = "cdns3,usbphy";
> 
> with:
>                  phys = <&usb2_phy>, <&usb3_phy>;
>                  phy-names = "cdns3,usbphy2", "cdns3,usbphy3";
> 
 
Yes, I think so.

Peter