linux-kernel - Re: [PATCH v2] drivers: net: dsa: fix warning same module names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZof4S9xySBLMnf6Uu4LuRSjoEyxJYv4EXTgKDOf5R8Ag@mail.gmail.com>
Date:   Wed, 12 Jun 2019 20:39:59 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Anders Roxell <anders.roxell@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drivers: net: dsa: fix warning same module names

On Wed, Jun 12, 2019 at 3:16 PM Andrew Lunn <andrew@...n.ch> wrote:
> On Wed, Jun 12, 2019 at 02:36:44PM +0200, Linus Walleij wrote:

> > Sorry for giving bad advice here on IRC... my wrong.
> >
> > > -obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek.o
> > > -realtek-objs                   := realtek-smi.o rtl8366.o rtl8366rb.o
> > > +obj-$(CONFIG_NET_DSA_REALTEK_SMI) += rtl8366.o
> > > +rtl8366-objs                   := realtek-smi.o rtl8366-common.o rtl8366rb.o
> >
> > What is common for this family is not the name rtl8366
> > (there is for example rtl8369 in this family, we just haven't
> > added it yet) but the common technical item is SMI.
>
> Hi Linus
>
> I was not sure about this. I thought SMI was the bus used to
> communicate with the switch. It just seemed odd to call a switch
> family after the bus.

It is true, but as can be seen from:
Documentation/devicetree/bindings/net/dsa/realtek-smi.txt
it is a family of 8 switches. I think we should just have
one module handling all of them for simplicity, once we
get around to implementing anything else than RTL8366RB
that is.

It's these 8 switches that talk SMI and they have a lot
in common like talking RRCP internally AFAICT.
I think these switches are pretty complex on the inside,
we just don't have very good documentation :/

> Anyway, if you are happy with the name realtek-smi:
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Thanks!

Yours,
Linus Walleij