linux-kernel - Re: [PATCH v2] drivers: net: dsa: fix warning same module names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190612131647.GD23615@lunn.ch>
Date:   Wed, 12 Jun 2019 15:16:47 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Anders Roxell <anders.roxell@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drivers: net: dsa: fix warning same module names

On Wed, Jun 12, 2019 at 02:36:44PM +0200, Linus Walleij wrote:
> On Wed, Jun 12, 2019 at 10:11 AM Anders Roxell <anders.roxell@...aro.org> wrote:
> 
> > When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY
> > enabled as loadable modules, we see the following warning:
> >
> > warning: same module names found:
> >   drivers/net/phy/realtek.ko
> >   drivers/net/dsa/realtek.ko
> >
> > Rework so the driver name is rtl8366 instead of realtek.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> 
> Sorry for giving bad advice here on IRC... my wrong.
> 
> > -obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek.o
> > -realtek-objs                   := realtek-smi.o rtl8366.o rtl8366rb.o
> > +obj-$(CONFIG_NET_DSA_REALTEK_SMI) += rtl8366.o
> > +rtl8366-objs                   := realtek-smi.o rtl8366-common.o rtl8366rb.o
> 
> What is common for this family is not the name rtl8366
> (there is for example rtl8369 in this family, we just haven't
> added it yet) but the common technical item is SMI.

Hi Linus

I was not sure about this. I thought SMI was the bus used to
communicate with the switch. It just seemed odd to call a switch
family after the bus.

Anyway, if you are happy with the name realtek-smi: 

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew