linux-kernel - Re: [PATCH v2] drivers: net: dsa: fix warning same module names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Jun 2019 14:36:44 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drivers: net: dsa: fix warning same module names

On Wed, Jun 12, 2019 at 10:11 AM Anders Roxell <anders.roxell@...aro.org> wrote:

> When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY
> enabled as loadable modules, we see the following warning:
>
> warning: same module names found:
>   drivers/net/phy/realtek.ko
>   drivers/net/dsa/realtek.ko
>
> Rework so the driver name is rtl8366 instead of realtek.
>
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

Sorry for giving bad advice here on IRC... my wrong.

> -obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek.o
> -realtek-objs                   := realtek-smi.o rtl8366.o rtl8366rb.o
> +obj-$(CONFIG_NET_DSA_REALTEK_SMI) += rtl8366.o
> +rtl8366-objs                   := realtek-smi.o rtl8366-common.o rtl8366rb.o

What is common for this family is not the name rtl8366
(there is for example rtl8369 in this family, we just haven't
added it yet) but the common technical item is SMI.

So I would suggest something like:

obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek-smi.o
realtek-smi-objs := realtek-smi-core.o rtl8366.o rtl8366rb.o

I.e. rename the realtel-smi.c to realtek-smi-core.c instead
and go with that.

With that change:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij