linux-kernel - Re: [PATCH v4 3/3] livepatch: Remove duplicate warning about missing reliable stacktrace support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190612135223.GC8298@JAVRIS.in.ibm.com>
Date:   Wed, 12 Jun 2019 19:22:23 +0530
From:   Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To:     Miroslav Benes <mbenes@...e.cz>
Cc:     jpoimboe@...hat.com, jikos@...nel.org, pmladek@...e.com,
        joe.lawrence@...hat.com, live-patching@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] livepatch: Remove duplicate warning about missing
 reliable stacktrace support

On Tue, Jun 11, 2019 at 04:13:20PM +0200, Miroslav Benes wrote:
> From: Petr Mladek <pmladek@...e.com>
> 
> WARN_ON_ONCE() could not be called safely under rq lock because
> of console deadlock issues. Moreover WARN_ON_ONCE() is superfluous in
> klp_check_stack(), because stack_trace_save_tsk_reliable() cannot return
> -ENOSYS thanks to klp_have_reliable_stack() check in
> klp_try_switch_task().
> 
> Signed-off-by: Petr Mladek <pmladek@...e.com>
> [ mbenes: changelog edited ]
> Signed-off-by: Miroslav Benes <mbenes@...e.cz>

Reviewed-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>