linux-kernel - Re: [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190615204320.i4qxbk2m3ee73vyg@treble>
Date:   Sat, 15 Jun 2019 15:43:20 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Miroslav Benes <mbenes@...e.cz>
Cc:     jikos@...nel.org, pmladek@...e.com, joe.lawrence@...hat.com,
        kamalesh@...ux.vnet.ibm.com, live-patching@...r.kernel.org,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings

On Tue, Jun 11, 2019 at 04:13:17PM +0200, Miroslav Benes wrote:
> This is the fourth attempt to improve the situation of reliable stack
> trace warnings in livepatch. Based on discussion in
> 20190531074147.27616-1-pmladek@...e.com (v3).
> 
> Changes against v3:
> + weak save_stack_trace_tsk_reliable() removed, because it is not needed
>   anymore thanks to Thomas' recent improvements
> + klp_have_reliable_stack() check reintroduced in klp_try_switch_task()
> 
> Changes against v2:
> 
> + Put back the patch removing WARN_ONCE in the weak
>   save_stack_trace_tsk_reliable(). It is related.
> + Simplified patch removing the duplicate warning from klp_check_stack()
> + Update commit message for 3rd patch [Josh]
> 
> Miroslav Benes (2):
>   stacktrace: Remove weak version of save_stack_trace_tsk_reliable()
>   Revert "livepatch: Remove reliable stacktrace check in
>     klp_try_switch_task()"
> 
> Petr Mladek (1):
>   livepatch: Remove duplicate warning about missing reliable stacktrace
>     support
> 
>  kernel/livepatch/transition.c | 8 +++++++-
>  kernel/stacktrace.c           | 8 --------
>  2 files changed, 7 insertions(+), 9 deletions(-)

Thanks Miroslav for wrapping this up, and thanks to Petr for his
previous work on this.

Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>

-- 
Josh