linux-kernel - Re: [PATCH] gsmi: replace printk with relevant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Jun 2019 23:46:06 +0530
From:   Saiyam Doshi <saiyamdoshi.in@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     groeck@...gle.com, linux-kernel@...r.kernel.org,
        groeck@...omium.org, adurbin@...omium.org, dlaurie@...omium.org
Subject: Re: [PATCH] gsmi: replace printk with relevant dev_<level>

On Fri, Jun 14, 2019 at 08:09:19AM +0200, Greg KH wrote:
> On Fri, Jun 14, 2019 at 12:27:05AM +0530, Saiyam Doshi wrote:
> > Replace printk() with dev_* macros for logging consistency.
> > In process of replacing printk with dev_err, dev_info etc.,
> > removed unnecessary "out of memory" debug message.
> 
> That is multiple things done in the same patch, please break this up
> into a patch series, only doing one "logical" thing per patch.

Agreed. I could have broken it into patch set.

> Note, generic cleanup patches like this are tough to get done in the
> "real" part of the kernel, I strongly recommend you start out in
> drivers/staging/ where these types of changes are welcomed.  Get
> experience there and then move out into other areas of the kernel if you
> want to, that way you don't annoy developers/maintainers with basic
> errors like this.
> 
> good luck!

Noted. Thanks Greg for feedback and suggestion.