lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 14 Jun 2019 08:09:19 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Saiyam Doshi <saiyamdoshi.in@...il.com>
Cc:     groeck@...gle.com, linux-kernel@...r.kernel.org,
        groeck@...omium.org, adurbin@...omium.org, dlaurie@...omium.org
Subject: Re: [PATCH] gsmi: replace printk with relevant dev_<level>

On Fri, Jun 14, 2019 at 12:27:05AM +0530, Saiyam Doshi wrote:
> Replace printk() with dev_* macros for logging consistency.
> In process of replacing printk with dev_err, dev_info etc.,
> removed unnecessary "out of memory" debug message.

That is multiple things done in the same patch, please break this up
into a patch series, only doing one "logical" thing per patch.

Note, generic cleanup patches like this are tough to get done in the
"real" part of the kernel, I strongly recommend you start out in
drivers/staging/ where these types of changes are welcomed.  Get
experience there and then move out into other areas of the kernel if you
want to, that way you don't annoy developers/maintainers with basic
errors like this.

good luck!

greg k-h

Powered by blists - more mailing lists