linux-kernel - Re: [RFC PATCH 2/3] x86/cpufeatures: Combine word 11 and 12 into new scattered features word 11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190614184423.GG198207@romley-ivt3.sc.intel.com>
Date:   Fri, 14 Jun 2019 11:44:23 -0700
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Sean Christopherson <sean.j.christopherson@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, H Peter Anvin <hpa@...or.com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        x86 <x86@...nel.org>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [RFC PATCH 2/3] x86/cpufeatures: Combine word 11 and 12 into new
 scattered features word 11

On Fri, Jun 14, 2019 at 05:02:19PM +0200, Borislav Petkov wrote:
> On Fri, Jun 14, 2019 at 07:25:51AM -0700, Fenghua Yu wrote:
> > But without this small patch, CPUID_7_EDX is 17 instead of
> > NCAPINTS(19)-1=18 in patch 0002. Of course CPUID_7_EDX is 18 correctly
> > evetually after applying patch 0003 which add the word 12 back.
> 
> Ok, then I guess the easiest should be if not remove defines from
> cpuid_leafs but rename them, no?

So I will re-name the defines in cpuid_leafs to CPUID_LNX_4 and CPUID_DUMMY
to match status of word 11 and word 12.

Hopefully that's ok?

Thanks.

-Fenghua