linux-kernel - Re: [PATCH] Input: cros_ec_keyb: mask out extra flags in event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190614185533.GA142889@dtor-ws>
Date:   Fri, 14 Jun 2019 11:55:33 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Enrico Granata <egranata@...gle.com>
Cc:     Ting Shen <phoenixshen@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Enrico Granata <egranata@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Guenter Roeck <groeck@...omium.org>,
        Brian Norris <briannorris@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        linux-input@...r.kernel.org,
        Colin Ian King <colin.king@...onical.com>
Subject: Re: [PATCH] Input: cros_ec_keyb: mask out extra flags in event_type

On Fri, Jun 14, 2019 at 11:27:03AM -0700, Enrico Granata wrote:
> On Thu, Jun 13, 2019 at 11:54 PM Ting Shen <phoenixshen@...omium.org> wrote:
> >
> > http://crosreview.com/1341159 added a EC_MKBP_HAS_MORE_EVENTS flag to
> > the event_type field, the receiver side should mask out this extra bit when
> > processing the event.
> >
> > Signed-off-by: Ting Shen <phoenixshen@...omium.org>
> 
> Reviewed-by: Enrico Granata <egranata@...gle.com>

EC_MKBP_EVENT_TYPE_MASK is not in Linus' tree. It would be better to
merge this path through whatever tree that is bringing in that
definition.

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Thanks.

-- 
Dmitry