lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 14 Jun 2019 14:27:30 -0700
From:   Alexei Starovoitov <>
To:     Josh Poimboeuf <>
Cc:     X86 ML <>, Alexei Starovoitov <>,
        LKML <>,
        Daniel Borkmann <>,
        Network Development <>,
        bpf <>, Peter Zijlstra <>,
        Song Liu <>,
        Kairui Song <>,
        Steven Rostedt <>,
        David Laight <>,
        Thomas Gleixner <>,
        Borislav Petkov <>, Ingo Molnar <>
Subject: Re: [PATCH v2 4/5] x86/bpf: Fix 64-bit JIT frame pointer usage

On Fri, Jun 14, 2019 at 2:19 PM Josh Poimboeuf <> wrote:
> On Fri, Jun 14, 2019 at 02:05:56PM -0700, Alexei Starovoitov wrote:
> > Have you tested it ?
> > I really doubt, since in my test both CONFIG_UNWINDER_ORC and
> > CONFIG_UNWINDER_FRAME_POINTER failed to unwind through such odd frame.
> Hm, are you seeing selftest failures?  They seem to work for me.
> > Here is much simple patch that I mentioned in the email yesterday,
> > but you failed to listen instead of focusing on perceived 'code readability'.
> >
> > It makes one proper frame and both frame and orc unwinders are happy.
> I'm on my way out the door and I just skimmed it, but it looks fine.
> Some of the code and patch description look familiar, please be sure to
> give me proper credit.

credit means something positive.
your contribution to bpf jit fix was negative.
I'm going to rewrite the fix from relying on patch 3.

Powered by blists - more mailing lists