linux-kernel - Re: [PATCH v7 18/18] x86/fsgsbase/64: Add documentation for FSGSBASE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1906161804570.1760@nanos.tec.linutronix.de>
Date:   Sun, 16 Jun 2019 18:05:23 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Bae, Chang Seok" <chang.seok.bae@...el.com>
cc:     Andy Lutomirski <luto@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        "H . Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        "x86@...nel.org" <x86@...nel.org>, Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v7 18/18] x86/fsgsbase/64: Add documentation for
 FSGSBASE

On Sun, 16 Jun 2019, Bae, Chang Seok wrote:

> 
> > On Jun 16, 2019, at 05:34, Thomas Gleixner <tglx@...utronix.de> wrote:
> > 
> > On Sun, 16 Jun 2019, Thomas Gleixner wrote:
> >> 
> >> Please dont. Send me a delta patch against the documentation. I have queued
> >> all the other patches already internally. I did not push it out because I
> >> wanted to have proper docs.
> > 
> > Fixed it up already. About to push it out.
> > 
> 
> Thanks. This is the diff though.
> 
> diff --git a/arch/x86/include/asm/preempt.h b/arch/x86/include/asm/preempt.h
> index 22992c8377952..f667087792747 100644
> --- a/arch/x86/include/asm/preempt.h
> +++ b/arch/x86/include/asm/preempt.h
> @@ -118,7 +118,7 @@ static __always_inline bool should_resched(int preempt_offset)
>  
>  	/* preempt count == 0 ? */
>  	tmp &= ~PREEMPT_NEED_RESCHED;
> -	if (tmp)
> +	if (tmp != preempt_offset)
>  		return false;
>  	if (current_thread_info()->preempt_lazy_count)
>  		return false;
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index c15583162a559..25bcf2f2714ba 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -92,6 +92,34 @@ static inline void softirq_clr_runner(unsigned int sirq)
>  	sr->runner[sirq] = NULL;
>  }
>  
> +static bool softirq_check_runner_tsk(struct task_struct *tsk,
> +				     unsigned int *pending)

WHAT? How is this related ?