[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <325855d0-00f9-df8a-ea57-c140d39dd6ef@ti.com>
Date: Sun, 16 Jun 2019 18:14:16 +0530
From: Vignesh Raghavendra <vigneshr@...com>
To: Sagar Shrikant Kadam <sagar.kadam@...ive.com>,
<marek.vasut@...il.com>, <tudor.ambarus@...rochip.com>,
<dwmw2@...radead.org>, <computersforpeace@...il.com>,
<miquel.raynal@...tlin.com>, <richard@....at>,
<linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
<linux-riscv@...ts.infradead.org>
CC: <palmer@...ive.com>, <aou@...s.berkeley.edu>,
<paul.walmsley@...ive.com>, <wesley@...ive.com>
Subject: Re: [PATCH v5 1/3] mtd: spi-nor: add support for is25wp256
Hi,
On 12-Jun-19 4:17 PM, Sagar Shrikant Kadam wrote:
[...]
> @@ -4129,7 +4137,7 @@ int spi_nor_scan(struct spi_nor *nor, const char *name,
> if (ret)
> return ret;
>
> - if (nor->addr_width) {
> + if (nor->addr_width && JEDEC_MFR(info) != SNOR_MFR_ISSI) {
> /* already configured from SFDP */
Hmm, why would you want to ignore addr_width that's read from SFDP table?
Regards
Vignesh
> } else if (info->addr_width) {
> nor->addr_width = info->addr_width;
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index b3d360b..ff13297 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -19,6 +19,7 @@
> #define SNOR_MFR_ATMEL CFI_MFR_ATMEL
> #define SNOR_MFR_GIGADEVICE 0xc8
> #define SNOR_MFR_INTEL CFI_MFR_INTEL
> +#define SNOR_MFR_ISSI 0x9d /* ISSI */
> #define SNOR_MFR_ST CFI_MFR_ST /* ST Micro */
> #define SNOR_MFR_MICRON CFI_MFR_MICRON /* Micron */
> #define SNOR_MFR_MACRONIX CFI_MFR_MACRONIX
>
Powered by blists - more mailing lists